{ServiceBus} az servicebus namespace failover: Update docstring from GeoDR Failover to Geo-Replication Failover#32676
Open
EldertGrootenboer wants to merge 1 commit intoAzure:devfrom
Open
Conversation
EldertGrootenboer
requested review from
evelyn-ys,
jsntcy and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @EldertGrootenboer, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the docstring for the Azure Service Bus namespace failover command to use "Geo-Replication Failover" instead of "GeoDR Failover" to clarify that this relates to the new Geo-Replication feature.
Changes:
- Updated class docstring from "GeoDR Failover" to "Geo-Replication Failover"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ) | ||
| class Failover(AAZCommand): | ||
| """GeoDR Failover | ||
| """Geo-Replication Failover |
There was a problem hiding this comment.
While updating this docstring from "GeoDR" to "Geo-Replication" improves clarity, there are other occurrences of "GeoDR" in the codebase that should also be updated for consistency. Specifically:
- src/azure-cli/azure/cli/command_modules/servicebus/aaz/latest/servicebus/namespace/_create.py line 236: "GeoDR Role Types"
- src/azure-cli/azure/cli/command_modules/servicebus/aaz/latest/servicebus/namespace/_update.py line 99: "GeoDR Role Types"
Consider updating these references to use "Geo-Replication" terminology consistently across the module.
calvinhzy
changed the title
az servicebus namespace failover: Update docstring from GeoDR Failover to Geo-Replication Failover
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az servicebus namespace failover
Description
Clarify that this is for the new Geo-Replication feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.